Skip to content

Introduce Props Bot workflow. #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Introduce Props Bot workflow. #964

merged 1 commit into from
Feb 1, 2024

Conversation

aaronjorbin
Copy link
Member

Props Bot is a new GitHub Action that will compile a list of contributors for a given pull request. The bot will leave a comment with a list of contributors formatted for use in both Trac SVN and GitHub. See: https://make.wordpress.org/core/2024/02/01/new-commit-message-requirements-in-git-hello-props-bot/

Summary

Props Bot is a new GitHub Action that will compile a list of contributors for a given pull request. The bot will leave a comment with a list of contributors formatted for use in both Trac SVN and GitHub.

Relevant technical choices

I used yml since that is what github requires.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

Sorry, something went wrong.

Props Bot is a new GitHub Action that will compile a list of contributors for a given pull request. The bot will leave a comment with a list of contributors formatted for use in both Trac SVN and GitHub. See: https://make.wordpress.org/core/2024/02/01/new-commit-message-requirements-in-git-hello-props-bot/
@aaronjorbin aaronjorbin added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 1, 2024
@aaronjorbin
Copy link
Member Author

The Toronto Maple Leafs would like to have a word with the spell check (which is also complaining about a different file)

Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

github-actions bot commented Feb 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: jorbin, swissspidy, westonruter.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy requested review from westonruter and joemcgill and removed request for felixarntz February 1, 2024 21:26
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: props-bot.yml is identical to the file with the same path in Gutenberg, aside from different indentation.

@westonruter westonruter merged commit 4be732e into trunk Feb 1, 2024
@westonruter westonruter deleted the add/props-bot-action branch February 1, 2024 21:54
@westonruter
Copy link
Member

westonruter commented Feb 1, 2024

The Toronto Maple Leafs would like to have a word with the spell check (which is also complaining about a different file)

Fixed in #965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants