Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for badly named files #629

Merged
merged 20 commits into from
Oct 9, 2024
Merged

Look for badly named files #629

merged 20 commits into from
Oct 9, 2024

Conversation

davidperezgar
Copy link
Member

Fixes #628

@davidperezgar davidperezgar linked an issue Sep 12, 2024 that may be closed by this pull request
Check: Badly named files (spaces etc) #628
Closed
@davidperezgar davidperezgar changed the title look for badly names Look for badly named files Sep 12, 2024
@davidperezgar davidperezgar self-assigned this Sep 12, 2024
@davidperezgar davidperezgar marked this pull request as ready for review September 14, 2024 07:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 14, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ernilambar
ernilambar reviewed Sep 14, 2024
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
@davidperezgar
Copy link
Member Author

Stills need duplicated filenames

@davidperezgar
Copy link
Member Author

I believe that is done!

@davidperezgar
Copy link
Member Author

This PR is stucked, so I'm going to remove the check of duplicated names to other issue/PR.

felixarntz
felixarntz requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidperezgar The new logic looks good, but can you please use a conditional for this like all other parts of this check do, so that it can be controlled whether or not to include this?

includes/Checker/Checks/Plugin_Repo/File_Type_Check.php Outdated Show resolved Hide resolved
tests/phpunit/tests/Checker/Checks/File_Type_Check_Tests.php Outdated Show resolved Hide resolved
felixarntz
felixarntz approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @davidperezgar, this looks great!

@davidperezgar
Copy link
Member Author

Awesome!

@davidperezgar
Copy link
Member Author

I'll add it for 1.2.0.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Oct 9, 2024
@ernilambar ernilambar added this to the 1.2.0 milestone Oct 9, 2024
ernilambar
ernilambar reviewed Oct 9, 2024
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
@davidperezgar davidperezgar merged commit 11cff79 into trunk Oct 9, 2024
28 checks passed
@davidperezgar davidperezgar deleted the 628-check-badly-named-files-spaces-etc branch October 9, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernilambar ernilambar ernilambar left review comments

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

Assignees

@davidperezgar davidperezgar

Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Check: Badly named files (spaces etc)
4 participants
@davidperezgar @swissspidy @ernilambar @felixarntz