Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create new comment for visibility #125

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

What?

Always create a new comment at the bottom of the PR.

Why?

To increase visibility of the comment, and make it harder to miss.

The problem with editor the comment is that is maintains the same position on a PR.

  • When the time of merging comes, it's easy to forget adding the props, because the message is not directly in front of you.
  • When remembering to add them, you have to scroll back and find the comment.
  • Often, on much discussed and reviewed PRs, this comment will disappear because Github hides/collapses older comments.

How?

Instead of editing the previous comment, delete it. Then always add a fresh comment, which will appear at the bottom.

Testing Instructions

You can see a test run on WordPress/gutenberg#62756: https://github.com/WordPress/gutenberg/actions/runs/9616861940/job/26528178346?pr=62756

@ellatrix ellatrix added the [Action] Props Bot Relating to the Props Bot action label Jun 21, 2024
@ellatrix ellatrix requested review from desrosj and aaronjorbin June 21, 2024 17:03
@desrosj
Copy link
Contributor

desrosj commented Oct 8, 2024

@ellatrix and I chatted about this on a few occasions. The intention here was to improve maintainer workflows and avoid forgetting to add props when merging. But this approach would result in many more notifications, especially on PRs with high levels of activity.

Going to close this out.

@desrosj desrosj closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Props Bot Relating to the Props Bot action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants