Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

these owners aren't WordPress owners #7

Merged
merged 1 commit into from
Jan 9, 2024
Merged

these owners aren't WordPress owners #7

merged 1 commit into from
Jan 9, 2024

Conversation

aaronjorbin
Copy link
Member

I think it is best to wait on setting Code Owners until this is a bit more mature and when that does happen, it should be a WordPress group.

Copy link

github-actions bot commented Jan 9, 2024

Here is a list of everyone that appears to have contributed to this PR and any linked issues:

# Committers
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>

# Reviewers
Co-authored-by: desrosj <desrosj@git.wordpress.org>

# Commenters


# Reporters


# Unconnected

props-bot-action

@aaronjorbin
Copy link
Member Author

aaronjorbin commented Jan 9, 2024

I also think that when it comes back it should be in the .github directory.

@desrosj can you take a look at this?

@jeffpaul Any thoughts?

@desrosj
Copy link
Contributor

desrosj commented Jan 9, 2024

Moving makes sense. I'm fine with deleting the file till later, leaving it empty, or adding myself (and maybe you?) to the code owners.

@aaronjorbin
Copy link
Member Author

I think no file to start. In my eyes, codeowners is something that should be done only when a codebase is large enough that it's hard for someone to easily contribute all over it. And a blank file is more distracting than a non-existent one.

@desrosj desrosj merged commit fd418b6 into trunk Jan 9, 2024
3 checks passed
@desrosj desrosj deleted the removeOwners branch January 9, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants