New theme- Mixin' Styles- GB #208
Conversation
| @@ -0,0 +1,27 @@ | |||
| // Register new block variations | |||
There was a problem hiding this comment.
This is not needed anymore. Define the template area and template parts in experimental-theme.json WordPress/gutenberg#30118
| @@ -0,0 +1,126 @@ | |||
| <?php | |||
There was a problem hiding this comment.
These are not needed anymore, you can add both the colors and gradients to experimental-theme.json
mixin-styles-gb/functions.php
Outdated
| // Stylesheets | ||
| wp_enqueue_style( 'mixin-styles-gb-style', get_stylesheet_uri() ); | ||
|
|
||
| if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) { |
There was a problem hiding this comment.
This is not needed anymore, it is enqueued with the comments block
| } | ||
| ] | ||
| }, | ||
| "custom": { |
There was a problem hiding this comment.
Replace these with "Layout" WordPress/gutenberg#29335
mixin-styles-gb/comments.php
Outdated
| @@ -0,0 +1,42 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Removing this no longer causes a PHP waring
| @@ -0,0 +1,7 @@ | |||
| <!-- wp:paragraph --> | |||
There was a problem hiding this comment.
A website can't be copyrighted to a theme =D
| @@ -0,0 +1,35 @@ | |||
| <!-- wp:group {"className":"mxs-wrapper"} --> | |||
| <div class="wp-block-group mxs-wrapper"><div class="wp-block-group__inner-container"><!-- wp:template-part {"slug":"header","theme":"mixin-styles-gb","tagName":"header","align":"full","className":"mxs-header mxs-header\u002d\u002dmain"} /--> | |||
There was a problem hiding this comment.
Remove all "theme":"mixin-styles-gb" from template parts that are not nested, inner blocks, or the "template part not found" error message will show.
There was a problem hiding this comment.
When I remove "theme": "mixin-styles-gb" from each template part call, the header/footer disappears and is replaced with the message "Template part has been deleted or is unavailable."
There was a problem hiding this comment.
Are you using an older version of Gutenberg? Try the development version from GitHub.
There was a problem hiding this comment.
I downloaded and installed the development version and the issue still exists. Do I need to recreate the header/footer or anything?
There was a problem hiding this comment.
Delete any existing templates that are saved under appearance > templates
There was a problem hiding this comment.
All of the templates were removed from the Appearance menu as well, but I still can't get the template parts to show up.
There was a problem hiding this comment.
After moving the generated code outside of the group block, I see that it works. Based on this, I will move the code and adjust the CSS to how it looked before.
| @@ -0,0 +1,35 @@ | |||
| <!-- wp:group {"className":"mxs-wrapper"} --> | |||
| <div class="wp-block-group mxs-wrapper"><div class="wp-block-group__inner-container"><!-- wp:template-part {"slug":"header","theme":"mixin-styles-gb","tagName":"header","align":"full","className":"mxs-header mxs-header\u002d\u002dmain"} /--> | |||
There was a problem hiding this comment.
Remove the inner-container from all group blocks. This is related to WordPress/gutenberg#29335
|
Thank you for looking over and reviewing this theme.
This week will be quite busy but I will be making the requested changes
over the next few weeks or so, as well as updating to latest Gutenberg
version.
Thanks again,
Jason Gonzalez
…On Thu, Mar 25, 2021, 8:43 PM Carolina Nymark ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In mixin-styles-gb/block-templates/404.html
<#208 (comment)>
:
> @@ -0,0 +1,35 @@
+<!-- wp:group {"className":"mxs-wrapper"} -->
+<div class="wp-block-group mxs-wrapper"><div class="wp-block-group__inner-container"><!-- wp:template-part {"slug":"header","theme":"mixin-styles-gb","tagName":"header","align":"full","className":"mxs-header mxs-header\u002d\u002dmain"} /-->
Remove the inner-container from all group blocks. This is related to
WordPress/gutenberg#29335
<WordPress/gutenberg#29335>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#208 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGAETUXDCSNAHMN6XDBTIUDTFP7G3ANCNFSM4XVPV6BA>
.
|
New full site theme Mixin' Styles- GB.