Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

alignleft and alignright are switched on RTL #325

Closed
joyously opened this issue Oct 25, 2018 · 5 comments · Fixed by #425
Closed

alignleft and alignright are switched on RTL #325

joyously opened this issue Oct 25, 2018 · 5 comments · Fixed by #425
Labels
bug Something isn't working has patch
Milestone
RC1

Comments

@joyously
Copy link

In RTL mode, alignleft is on the right and alignright is on the left. These should not change with RTL.

rtl-image-alignement
@kjellr kjellr added the bug Something isn't working label Oct 25, 2018
@kjellr kjellr added this to the RC1 milestone Oct 30, 2018
jasmussen pushed a commit that referenced this issue Oct 31, 2018
Fix RTL alignments
c459c17 
This fixes #325.

It should be paired with WordPress/gutenberg#11293.

This PR adds RTL ignore comments to the block alignment classes so the values are not overridden.
@jasmussen jasmussen mentioned this issue Oct 31, 2018
Merged
@kjellr
Copy link
Collaborator

kjellr commented Oct 31, 2018

Should be fixed as of #425. Block alignments may still be a little off until
WordPress/gutenberg#11293 is merged into Gutenberg. 👍

@joyously
Copy link
Author

joyously commented Nov 3, 2018

This is only partially fixed.
stand-alone left is OK
stand-alone right is on the right, but margin is also
captioned left is on the right
captioned right is on the left

rtl-switch

@kjellr
Copy link
Collaborator

kjellr commented Nov 3, 2018

Reopening as per @joyously's note above.

@kjellr kjellr reopened this Nov 3, 2018
@kjellr kjellr mentioned this issue Nov 5, 2018
Merged
@joyously
Copy link
Author

Once more time!
Everything looks good except the margin on alignright on RTL.

markup image alignment a review site -4808

@allancole
Copy link
Collaborator

Reopening as per @joyously's note above.

@allancole allancole reopened this Nov 11, 2018
kjellr added a commit that referenced this issue Nov 12, 2018
@kjellr
Adjust RTL float styles.
eecdecd 
Fix margins for right-floated blocks, and sync up margin spacing between blocks and non-block elements.

Fixes #325 (Again 🙂)
@kjellr kjellr mentioned this issue Nov 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working has patch
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Fix RTL alignments WordPress/twentynineteen
3 participants
@allancole @kjellr @joyously