This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Consolidate editor styles #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A followup to #22. This PR removes our secondary `style-editor-frame.css` file, and consolidates all of our editor styles into `style-editor.css`. Initially, the standard editor stylesheet was limited in scope to individual blocks, which meant we were unable to style the general alignment of the page, as well as items like the page title and default appender. The scope of `style-editor.css` is being expanded in WordPress/gutenberg#10956 , so we're now able to style those elements in a single stylesheet. Some minor style tweaks were necessary to make our original styles work in this context, but for the most part this is identical to #22.
Use of [data-align] selectors appears to be here to stay, so no need to point this out in the header.
Since it's no longer used for the editor frame styles.
So that it builds in case we need to edit it later on.
|
@allancole This should be good to go, and should be included in Beta 3, alongside Gutenberg 4.2. To test:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗️ This shouldn't be merged until WordPress/gutenberg#10956 is officially part of Gutenberg (Planned for the Gutenberg 4.2 Release)❗️
A followup to #22.
This PR removes our secondary
style-editor-frame.cssfile, and consolidates all of our editor styles intostyle-editor.css. Initially, the standard editor stylesheet was limited in scope to individual blocks, which meant we were unable to style the general alignment of the page, as well as items like the page title and default appender.The scope of
style-editor.cssis being expanded in WordPress/gutenberg#10956 , so we're now able to style those elements in a single stylesheet.Some minor style tweaks were necessary to make our original styles work in this context, but for the most part this is identical to #22.