-
Notifications
You must be signed in to change notification settings - Fork 127
Add pattern: Services - Three Columns #114
Add pattern: Services - Three Columns #114
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @huzaifaalmesbah!
I left a few comments on the code, to improve some things. I'd like to ask is if we can work on the indentation of the code. And also, if we can include artifacts when we're adding PRs that include changes that are visual (screenshot or screencast will work). Thanks 🙌
Co-authored-by: Juan Aldasoro <juanfraa@gmail.com>
Thank you for reviewing, @juanfra. I made the changes according to your suggestion. |
Thanks for the PR @huzaifaalmesbah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @huzaifaalmesbah
It looks like we need to do a few adjustments to the layout. And also add the alt
to the images. Please check the following screencast
Screen.Recording.2024-08-27.at.15.02.42.mov
Co-authored-by: Juan Aldasoro <juanfraa@gmail.com>
Hello @juanfra, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @huzaifaalmesbah
I still see that the layout needs to respect the width of the designs.
Screen.Recording.2024-08-28.at.09.22.53.mov
On this comment, I showed a way you could potentially fix it. I also see that the code needs indentation.
Can you please work on these things? Thanks in advance.
Huzaifa-20240828184842.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @huzaifaalmesbah
The layout looks good now. Can you please work on the indentation? Once that's fixed this one should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @huzaifaalmesbah 🏅
Fixes #80