This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Try: Add 3 section styles, update Hero: Centered Heading pattern. #151
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/theme.json", | ||
| "version": 3, | ||
| "slug": "section-1", | ||
| "title": "Style 1", | ||
| "blockTypes": [ | ||
| "core/group", | ||
| "core/columns", | ||
| "core/column" | ||
| ], | ||
| "styles": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--accent-2)", | ||
| "text": "var(--wp--preset--color--contrast)" | ||
| }, | ||
| "blocks": { | ||
| "core/separator": { | ||
| "color": { | ||
| "text": "color-mix(in srgb, currentColor 25%, transparent)" | ||
|
There was a problem hiding this comment. @carolinan @beafialho Let me know if I got this right! I only found a few separator designs in the Figma. |
||
| } | ||
| } | ||
| }, | ||
| "elements": { | ||
| "button": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--contrast)", | ||
| "text": "var(--wp--preset--color--base)" | ||
| } | ||
| }, | ||
| "link": { | ||
| "color": { | ||
| "text": "var(--wp--preset--color--contrast)" | ||
|
There was a problem hiding this comment. I think we could remove this, if we used currentColor in the parent theme.json. There was a problem hiding this comment. Otherwise if the user changes the text color, they'll also need to also change the link color. There was a problem hiding this comment. Oh yeah, good call! |
||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/theme.json", | ||
| "version": 3, | ||
| "slug": "section-2", | ||
richtabor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "title": "Style 2", | ||
| "blockTypes": [ | ||
| "core/group", | ||
| "core/columns", | ||
| "core/column" | ||
| ], | ||
| "styles": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--accent-3)", | ||
| "text": "var(--wp--preset--color--accent-2)" | ||
| }, | ||
| "blocks": { | ||
| "core/separator": { | ||
| "color": { | ||
| "text": "color-mix(in srgb, currentColor 25%, transparent)" | ||
| } | ||
| } | ||
| }, | ||
| "elements": { | ||
| "button": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--contrast)", | ||
| "text": "var(--wp--preset--color--base)" | ||
| } | ||
| }, | ||
| "link": { | ||
| "color": { | ||
| "text": "var(--wp--preset--color--accent-2)" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/theme.json", | ||
| "version": 3, | ||
| "slug": "section-3", | ||
| "title": "Style 3", | ||
| "blockTypes": [ | ||
| "core/group", | ||
| "core/columns", | ||
| "core/column" | ||
| ], | ||
| "styles": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--accent-1)", | ||
| "text": "var(--wp--preset--color--contrast)" | ||
| }, | ||
| "blocks": { | ||
| "core/separator": { | ||
| "color": { | ||
| "text": "color-mix(in srgb, currentColor 25%, transparent)" | ||
| } | ||
| } | ||
| }, | ||
| "elements": { | ||
| "button": { | ||
| "color": { | ||
| "background": "var(--wp--preset--color--contrast)", | ||
| "text": "var(--wp--preset--color--base)" | ||
| } | ||
| }, | ||
| "link": { | ||
| "color": { | ||
| "text": "var(--wp--preset--color--contrast)" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanfra let me know if it was intentional to explicitly set the heading color here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was not intentional.