Try: Add comments. #156
Try: Add comments. #156
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
patterns/hidden-comments.php
Outdated
| @@ -0,0 +1,51 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I wish twe didn't have to store templates in the patterns folder in order for them to be translatable. I guess there's no real way around that?
There was a problem hiding this comment.
No. I don't know if there is an open issue that covers it better than this one:
WordPress/gutenberg#20966
The project is closer to solving it now that there are block bindings.
In theory, block bindings could already be used, since you can use custom PHP functions which could include the translations.... but I don't think this theme should experiment with it.
There was a problem hiding this comment.
Also, this particular part of the theme is not a template or a part, it is intended to be a pattern so that it can be inserted anywhere, and it would be PHP file even if it had no translatable strings.
| @@ -931,6 +931,11 @@ | |||
| "lineHeight": "1.4" | |||
| }, | |||
| "blocks": { | |||
| "core/avatar": { | |||
| "border": { | |||
| "radius": "100px" | |||
There was a problem hiding this comment.
Would it make sense to create some radius presets, of which one preset could be "round", and just set to 9999px?
There was a problem hiding this comment.
There is a request in the Gutenberg repository to add this to the editor.
Let's check how far that has come, but I think it needs dev:
WordPress/gutenberg#64041
There was a problem hiding this comment.
I will add the issue to the list of issues.
theme.json
Outdated
| "typography": { | ||
| "fontSize": "var:preset|font-size|small" | ||
| } | ||
| }, | ||
| "core/post-comments-form": { | ||
| "css": "& textarea, input:not([type=submit]){border-radius:.25rem; border-color: var(--wp--preset--color--opacity-20) !important;} & input[type=checkbox]{margin:0 .2rem 0 0 !important;} & label {font-size: var(--wp--preset--font-size--x-small); }", |
There was a problem hiding this comment.
Some finnicky details here. But notably the input radius It'd be nice to again add to a preset scale, so they're consistent across.
|
Because the page templates are designed to not have comment areas by default, I think it would be good to not make this a hidden pattern. That way the user can add a new comment area that looks as good. |
|
Thank you, this is looking good to me! |
Rename the pattern file and remove inserter: no. Fix the block validation error with the comments area heading. Update the heading level hierarchy and the font sizes of the comments area heading and the comments title.
Replaced x-small with small
Description
Fixes #115
theme.json🗒️ Notes
5pxvalues now that we no longer have that as a preset.Screenshots
Screen.Recording.2024-08-29.at.17.28.54.mov
Testing Instructions