Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Twilight, Section 5: Adjust the border color for search input #650

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

alaminfirdows
Copy link
Contributor

Description
Closes #649

Adjust the border color on form elements in the search form block to make the inputs stand out against the white background. Previously, they were hard to see because the accent color was too similar to the background color.

Screenshots
image

Testing Instructions

  1. Open the Appearance menu, then go to Editor > Styles.
  2. Turn on the Twilight style variation.
  3. Create a new page.
  4. Add a Group Block to the page, then select Section Style 5 for it.
  5. Inside this section, insert a Search Block.
  6. Visit the page to see the section with the search block displayed.

Copy link

github-actions bot commented Oct 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alaminfirdows <alaminfirdows@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works well. I believe the !important is not needed here.

styles/05-twilight.json Outdated Show resolved Hide resolved
@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 28, 2024
@juanfra juanfra merged commit 45b89f8 into WordPress:trunk Oct 28, 2024
4 checks passed
@alaminfirdows alaminfirdows deleted the fix/search-input branch October 28, 2024 19:20
@alaminfirdows
Copy link
Contributor Author

Thanks @juanfra.

I've also noticed that there is some additional override code for the comment block. Shouldn't we consider removing it to avoid duplicating the code?

Ref: https://github.com/WordPress/twentytwentyfive/pull/650/files/a30575ef27ca892f079b2606a5120d2976d229d3#diff-60a85af5c000152e40c3680e65867153567c39f66b221f8200e757de4d123f5bR245

@juanfra
Copy link
Member

juanfra commented Oct 28, 2024

I am not sure if I understand. The two overrides are needed to fix the bug with the comments block and the search block. Can you please elaborate on why we should remove it?

@alaminfirdows
Copy link
Contributor Author

I wanted to point out that the comment block override has some additional changes that we don't really need. We should keep just the border color, but we can remove the other properties, such as border-radius, margin, and font-size.

What do you think about this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twilight, Section 5: Input field of the core/search block are not visible
2 participants