This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add fluid spacing scale #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2023
Closed
MaggieCabrera
approved these changes
Aug 28, 2023
|
These presets look good! I'm seeing a lot of spacing that was not supposed to be there, particularly in stack blocks in the home template. This may have happened everywhere else. It seems that it may have inheriting one of the presets, but one that's way too high? Here's what I mean, comparing it to a demo site I created with the intended spacings: spacings.mp4 |
|
Yea, we need to adjust the templates to use the system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a consistent fluid spacing scale that we can start leveraging in patterns, instead of using arbitrary values. This proposal uses the Fibonacci sequence.
We can continue to iterate and refine the values, but I think it'd be good to have a consistent set to start working from.
Testing Instructions
Screenshots
Desktop:
Mobile:
Example of this fluid spacing expressed in a pattern, with
40as the outer padding: