Consolidate single templates #172
Conversation
|
Yes, let's include the featured image on the page template as well as in the mockup. |
There was a problem hiding this comment.
Looks good.
Following are few minor queries.
Not sure if the space between the image and header is accurate. @beafialho could you confirm.
Canary has the issue with corner adjustment: (top left)
|
Thanks for taking a look @madhusudhand!
Good spot, seems like the border radius needs to be applied to the featured image overlay in GB. It looks like the cover block has the same issue. I believe GB 14.1 is the latest version that's going to be included in WP 6.1, so I'm not sure we can include a fix as part of the release. I've opened an issue for this here: WordPress/gutenberg#44262 Should we stick with the 3 separate templates for now? |
|
WordPress/gutenberg#44286 / WordPress/gutenberg#44276 should unblock this 🎉 |
|
As WordPress/gutenberg#44286 is confirmed as being included in 6.1 Beta 3, I'm going to merge this so we can test these changes together as part of Beta 3. |
Now that WordPress/gutenberg#43676 has been merged, I believe we can consolidate the single templates as discussed here.
Should we include the featured image on the page template as well?