This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Try a really simple button hover state #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Oct 27, 2021
There was a problem hiding this comment.
I think this is mostly a design question.
From a developer perspective, it's true it will not break since we aren't changing the colors. But if I wanted to change the hover state I'd still need to edit the CSS. At that point, it seems like a nicer experience and result to just change two values in theme.json (as would be the case in #163).
|
Yeah... I don't like it. It was worth exploring, but I'll close for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #162, #163.
Solves #99.
I don't really like this treatment, but it's not horrible. It's also just a couple CSS rules and it doesn't break anything. 🤷♂️