Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Change Post Comments to Query Comments #192

Closed
wants to merge 1 commit into from

Conversation

scruffian
Copy link
Collaborator

Description

Post Comments isn't shipping in 5.9 so trying Query Comments instead as proposed in #179

Screenshots
Screenshot 2021-11-01 at 17 46 10

Testing Instructions

  1. Open a post/page with comments and see what they look like

@kjellr
Copy link
Collaborator

kjellr commented Nov 1, 2021

Does this need to have the post comments form in it too? I don't see the ability to add comments otherwise.

Also... how much styling is possible here? We'd like it to look like it does in trunk.

@scruffian
Copy link
Collaborator Author

I can't find a way to add the form without using the post comments block, which isn't shipping in 5.9. I'm not sure if this will be possible...

@kjellr
Copy link
Collaborator

kjellr commented Nov 1, 2021

I'm able to place it in manually via the site editor, and that generally seems to work?

<!-- wp:comments-query-loop -->
<div class="wp-block-comments-query-loop"><!-- wp:comment-template -->
<!-- wp:post-comment-author {"isLink":true} /-->

<!-- wp:post-comment-date {"format":"F j, Y g:i a","isLink":true,"fontSize":"small"} /-->

<!-- wp:post-comment-content /-->
<!-- /wp:comment-template --></div>
<!-- /wp:comments-query-loop -->

<!-- wp:post-comments-form /-->

@@ -0,0 +1,9 @@
<!-- wp:comments-query-loop -->
<div class="wp-block-comments-query-loop"><!-- wp:comment-template -->
<!-- wp:post-comment-author {"isLink":true} /-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to place it in manually via the site editor, and that generally seems to work?

I'm confused about how this is expected to work in 5.9.

The post-comment-author, post-comment-date, post-comment-content, and post-comments-form are all currently marked as experimental.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use blocks that are marked as experimental, they just don't show up in the inserter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that doesn't sound right.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment here to get some clarification: WordPress/gutenberg#35979 (comment)

@michalczaplinski
Copy link

Hi folks, I've noted here that I don't think we should use the Comments Query Loop block in the twentytwentytwo as it's still very basic and not ready to be included in 5.9.

@jffng
Copy link
Collaborator

jffng commented Nov 2, 2021

I think we can close this since post-comments will now be used in 5.9: WordPress/gutenberg#36132

Thanks for pushing the conversation forward with the PR @scruffian.

@jffng jffng closed this Nov 2, 2021
@scruffian scruffian deleted the update/query-comments branch November 3, 2021 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants