This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Try a subtle opacity change on button hovers #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
approved these changes
Dec 3, 2021
This was referenced Dec 7, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99.
Tries a subtle opacity adjustment for button hovers. It's a single CSS rule, generally works ok, and will mostly still let folks choose hover colors when/if that feature gets rolled into core. From a pure visual design perspective, it's not my first choice but it looks acceptable. If we're implementing button hovers, I think this is our best bet.
The only real downside is that it's not totally obvious that there's a hover state for outlined buttons on light backgrounds. But it still might be better than what we've got (which is no hover state at all).
Screenshots