-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
…ess/twentytwentytwo into add/header-block-patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are looking really good. I left some minor comments.
@@ -0,0 +1,26 @@ | |||
<?php | |||
/** | |||
* Large post titles block pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed that too -- I want to do a little digging and see what's causing it... I remember Gutenberg doing that a while ago but I thought it was fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed an upstream issue here for this one: WordPress/gutenberg#35551
Once #74 is in, can you switch the target branch to trunk to get the tests run? Assuming those are good, I say 🚢 |
@jffng Seems like that worked. Mind giving it one more look? |
Closes #13.
This PR adds the 5 query patterns from the original mockups.
Default Posts
This one mirrors the default index template.
Known issues:
Text-based grid of posts
Simple Blog Posts
Known issues:
Image grid posts
Known issues:
Large post titles
Known issues:
Irregular posts grid
Known issues: