Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add query block patterns #84

Merged
merged 29 commits into from
Oct 12, 2021
Merged

Add query block patterns #84

merged 29 commits into from
Oct 12, 2021

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Oct 11, 2021

Closes #13.

⚠️ This one relies on some of the block patterns setup from #74, so the PR builds on that for now.


This PR adds the 5 query patterns from the original mockups.


Default Posts

default

This one mirrors the default index template.

Known issues:


Text-based grid of posts

Screen Shot 2021-10-11 at 3 03 34 PM


Simple Blog Posts

Screen Shot 2021-10-11 at 3 11 06 PM

Known issues:


Image grid posts

image-grid

Known issues:


Large post titles

large-titles

Known issues:


Irregular posts grid

irregular-grid

Known issues:

  • Since this requires use of multiple query blocks, it cannot include post pagination.

@kjellr kjellr requested a review from jffng October 11, 2021 19:12
@kjellr kjellr self-assigned this Oct 11, 2021
Copy link
Collaborator

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are looking really good. I left some minor comments.

inc/patterns/query-default.php Outdated Show resolved Hide resolved
inc/patterns/query-image-grid.php Outdated Show resolved Hide resolved
inc/patterns/query-text-grid.php Outdated Show resolved Hide resolved
@@ -0,0 +1,26 @@
<?php
/**
* Large post titles block pattern
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is looking a little funky in the editor vs front-end:

Editor View
Screen Shot 2021-10-11 at 5 22 04 PM Screen Shot 2021-10-11 at 5 21 30 PM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that too -- I want to do a little digging and see what's causing it... I remember Gutenberg doing that a while ago but I thought it was fixed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed an upstream issue here for this one: WordPress/gutenberg#35551

inc/patterns/query-text-grid.php Outdated Show resolved Hide resolved
Co-authored-by: Jeff Ong <jonger4@gmail.com>
@jffng
Copy link
Collaborator

jffng commented Oct 12, 2021

Once #74 is in, can you switch the target branch to trunk to get the tests run? Assuming those are good, I say 🚢

Base automatically changed from add/header-block-patterns to trunk October 12, 2021 14:10
@kjellr
Copy link
Collaborator Author

kjellr commented Oct 12, 2021

@jffng Seems like that worked. Mind giving it one more look?

@kjellr kjellr merged commit dc12671 into trunk Oct 12, 2021
@kjellr kjellr deleted the add/query-block-patterns branch October 12, 2021 14:41
@kjellr kjellr mentioned this pull request Oct 12, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Patterns: Add Query Patterns
2 participants