-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage seems low #468
Labels
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran an Xdebug report locally and the overall coverage was
34%
before #427, and23%
after.I'm not a coverage zealot, and don't think
100%
is a reasonable, but100%
over the critical areas seems reasonable for a security plugin, especially before it becomes a canonical plugin or merges into Core.sjinks/wp-two-factor-provider-webauthn
has some e2e tests that might provide a head start. Adding more unit/integration tests would be nice too.Using
@codeCoverageIgnore
on the untestable and low-severity areas would also help make it more obvious if everything that should be covered actually is.Related: #467
The text was updated successfully, but these errors were encountered: