Block creating authentication cookies when inappropriate to do so. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er through wp-login.php for two-factor verification.
|
This appears to be impacting the core workflows used by this plugin. Could we please add some unit tests to go with these changes? |
15 tasks
I wasn't able to determine how best to add unit testing here, given the plugin doesn't appear to currently test it. Do you have any suggestions @kasparsd? |
|
This seems to work in my manual tests. @kasparsd , do you have any thoughts on the 2 comments above about automated tests? |
iandunn
reviewed
Dec 1, 2022
Co-authored-by: Ian Dunn <ian@iandunn.name>
|
Closing in favour of #502 which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #406 and #385 it's possible for plugins to accidentally bypass the two-factor requirement by setting cookies directly.
See #406 (comment) for more detailed reasonings.
Fixes #406, #385