TOTP: Allow 'Enter' key to submit the auth code form #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-a-y
changed the title
|
@kasparsd any thoughts on a review of this PR and whether it's ready for consideration in v0.8.0? |
|
Per yesterday's bug scrub, we're going to punt this to future release so that we can focus on the U2F deprecation in 0.8.0. |
|
#518 introduced automatic submit of the input if the input character count matches the expected code length, so it is now doing autosubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the TOTP method, if you have to add an authentication code for the QR code, you have to manually click on the
Submitbutton in order for the form to submit properly.This PR allows the
Enterkey to submit the auth code form, which is better for UX.If you'd rather have the inline JS put into an external file, let me know. Inline JS was already used in the
authentication_page()method so I followed suit.Fixes #91.