Add PHP8 linter and fix linter issues #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kasparsd
commented
Oct 7, 2022
kasparsd
commented
- Add a Composer script to lint for PHP 8.2 support.
- Add the check to CI, too.
- Fix the CSS linter issues introduced by Add <label> to provider name #387.
kasparsd
commented
Oct 7, 2022
| @@ -672,7 +672,7 @@ public static function login_html( $user, $login_nonce, $redirect_to, $error_msg | |||
| ?> | |||
| <li> | |||
| <a href="<?php echo esc_url( $login_url ); ?>"> | |||
| <?php $backup_provider->print_label(); ?> | |||
| <?php echo esc_html( $backup_provider->get_label() ); ?> | |||
There was a problem hiding this comment.
Don't trust the provider to return the label escaped.
class-two-factor-core.php
Outdated
| @@ -987,8 +987,7 @@ public static function user_two_factor_options( $user ) { | |||
| <th scope="row"><input id="enabled-<?php echo esc_attr( $class ); ?>" type="checkbox" name="<?php echo esc_attr( self::ENABLED_PROVIDERS_USER_META_KEY ); ?>[]" value="<?php echo esc_attr( $class ); ?>" <?php checked( in_array( $class, $enabled_providers, true ) ); ?> /></th> | |||
| <th scope="row"><input type="radio" name="<?php echo esc_attr( self::PROVIDER_USER_META_KEY ); ?>" value="<?php echo esc_attr( $class ); ?>" <?php checked( $class, $primary_provider_key ); ?> /></th> | |||
| <td> | |||
| <label for="enabled-<?php echo esc_attr( $class ); ?>"><?php $object->print_label(); ?></label> | |||
|
|
|||
| <label class="two-factor-method-label" for="enabled-<?php echo esc_attr( $class ); ?>"><?php esc_html( $object->get_label() ); ?></label> | |||
There was a problem hiding this comment.
Use a class to target the label for the method selector to avoid generic label styles leaking. This looks good now:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.