Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Backup code download with quotes in translations #494

Merged
merged 11 commits into from
Nov 28, 2022
Merged

Fix Backup code download with quotes in translations #494

merged 11 commits into from
Nov 28, 2022

Commits on Nov 9, 2022

  1. Fully encode the Backup codes contents for use within a data: uri. Th… 

    …is is needed in the event response.data.i18n.title contains a quote or other similar character.
    @dd32
    dd32 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    0799971 View commit details
    Browse the repository at this point in the history

  2. Remove HTML escaping from string that's used within JS - We don't wan… 

    …t this to be HTML encoded as it's presented within a plaintext file.
    @dd32
    dd32 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    112d3f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Move the interpolation of the site domain from Javascript to PHP. Thi… 

    …s switches from using the domain, to the home url.
    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0579a0b View commit details
    Browse the repository at this point in the history

  2. Move data: uri generation from Javascript into PHP to allow for futur… 

    …e testing.
    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7da96ff View commit details
    Browse the repository at this point in the history

  3. Use \r\n in the downloaded file, so that the text file is usable on W… 

    …indows.
    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    67c7cff View commit details
    Browse the repository at this point in the history

  4. Add unit tests that cover the XHR Backup code generation.

    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8b066a7 View commit details
    Browse the repository at this point in the history

  5. Change the XHR test to use the testcase provided user.

    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    13f4cee View commit details
    Browse the repository at this point in the history

  6. Remove the usage of filter_input() within Two_Factor_Backup_Codes::aj… 

    …ax_generate_json() to allow it to be unit testable.
    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    16ecbd7 View commit details
    Browse the repository at this point in the history

  7. Tests: Add tests that confirm an unauthorized user cannot generate co… 

    …des for another, but that an Administrator can, and that the codes are only usable by the correct user.
    @dd32
    dd32 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7c0a548 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Whitespace fixes for alignment based on PHPCS.

    @dd32
    dd32 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b315cf9 View commit details
    Browse the repository at this point in the history

  2. assertFalse() before assertTrue(), as upon success validate_code() … 

    …will delete the code.

This shouldn't have affected the test, as `$current_user` and `$user` should not match, but for safety..
    @dd32
    dd32 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4a40268 View commit details
    Browse the repository at this point in the history