Destroy existing sessions when activating 2FA. #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
requested changes
Jun 8, 2023
dd32
commented
Jun 26, 2023
Sessions are destroyed when: - No providers -> Some providers - Some providers -> Less providers
…l providers enabled.
|
@dd32 seems as this may be good to merge and unblock the 0.8.2 release, yeah? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upon a new 2FA provider being set, existing sessions for the user are destroyed.
Fixes #577
Why?
It's considered best-practice to terminate existing sessions when "enhancing" an authenticated session.
How?
For the current user, the active session is kept, other sessions are destroyed upon 2FA being activated.
For other users, all their sessions are terminated.
Testing Instructions
See #577
Screenshots or screencast
Changelog Entry
Security - When 2FA is activated for a user, destroy any existing sessions.