Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TOTP method when method is configured #643

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kasparsd
Copy link
Collaborator

@kasparsd kasparsd commented Sep 19, 2024

What?

Users expect a method to be enabled if they chose to configure it.

Why?

Fixes #556.

How?

Testing Instructions

Setup workflow:

  1. Configure the TOTP method by submitting the generated code.
  2. Confirm the TOTP method is now enabled in the table.

Reset workflow:

  1. Click on RESET TOTP method button.
  2. Confirm the TOTP method is now disabled in the table.

Screenshots or screencast

totp-actions.mp4

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.

@kasparsd kasparsd marked this pull request as ready for review September 19, 2024 12:22
@jeffpaul jeffpaul added this to the 0.10.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOTP: After successful set up, JS should check the "Enabled" checkbox for the TOTP provider
2 participants