Skip to content

Commit

Permalink
Editor: Limit scope of resizable menu container CSS.
Browse files Browse the repository at this point in the history
The CSS to make menu item containers resizable in the admin menu editor was too broadly scoped, and caused classic editor metaboxes to have unconstrained height. Limit the scope of the CSS changes to only impact menu item containers.

Reviewed by jorbin.
Merges [58747] to the 6.6 branch.

Props neotrope, sabernhardt, joedolson.
Fixes #61662.

git-svn-id: https://develop.svn.wordpress.org/branches/6.6@58758 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
hellofromtonya committed Jul 18, 2024
1 parent 87a074b commit 2a0d775
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 11 deletions.
12 changes: 1 addition & 11 deletions src/wp-admin/css/edit.css
Original file line number Diff line number Diff line change
Expand Up @@ -1271,23 +1271,13 @@ label.post-format-icon {
margin: 0;
}

.categorydiv,
.customlinkdiv,
.posttypediv,
.taxonomydiv {
max-height: inherit;
height: 100%;
}

.wp-tab-panel,
.categorydiv div.tabs-panel,
.customlinkdiv div.tabs-panel,
.posttypediv div.tabs-panel,
.taxonomydiv div.tabs-panel {
min-height: 42px;
/* Allow space for content after tab panels in nav menu editor. */
max-height: calc( 100% - 75px );
height: 100%;
max-height: 200px;
overflow: auto;
padding: 0 0.9em;
border: solid 1px #dcdcde;
Expand Down
18 changes: 18 additions & 0 deletions src/wp-admin/css/nav-menus.css
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,24 @@ ul.add-menu-item-tabs li {
max-height: inherit;
}

#menu-settings-column .categorydiv,
#menu-settings-column .customlinkdiv,
#menu-settings-column .posttypediv,
#menu-settings-column .taxonomydiv {
max-height: inherit;
height: 100%;
}

#menu-settings-column .wp-tab-panel,
#menu-settings-column .categorydiv div.tabs-panel,
#menu-settings-column .customlinkdiv div.tabs-panel,
#menu-settings-column .posttypediv div.tabs-panel,
#menu-settings-column .taxonomydiv div.tabs-panel {
/* Allow space for content after tab panels in nav menu editor. */
max-height: calc( 100% - 75px );
height: 100%;
}

.metabox-holder-disabled .postbox,
.metabox-holder-disabled .accordion-section-content,
.metabox-holder-disabled .accordion-section-title {
Expand Down

0 comments on commit 2a0d775

Please sign in to comment.