Skip to content

wp_die() updates for the Themes component #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

wp_die() updates for the Themes component #10096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347237a
Update wp_die() to include status codes where appropriate within file…
CallumBW95 Sep 30, 2025
d8c6bbe
Merge branch 'trunk' of github.com:CallumBW95/wordpress-develop into …
CallumBW95 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-admin/theme-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

if ( ! current_user_can( 'edit_themes' ) ) {
wp_die( '<p>' . __( 'Sorry, you are not allowed to edit templates for this site.' ) . '</p>' );
wp_die( '<p>' . __( 'Sorry, you are not allowed to edit templates for this site.' ) . '</p>', 403 );
}

// Used in the HTML title tag.
Expand Down Expand Up @@ -70,7 +70,7 @@
$theme = wp_get_theme( $stylesheet );

if ( ! $theme->exists() ) {
wp_die( __( 'The requested theme does not exist.' ) );
wp_die( __( 'The requested theme does not exist.' ), 404 );
}

if ( $theme->errors() && 'theme_no_stylesheet' === $theme->errors()->get_error_code() ) {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/theme-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
$tab = ! empty( $_REQUEST['tab'] ) ? sanitize_text_field( $_REQUEST['tab'] ) : '';

if ( ! current_user_can( 'install_themes' ) ) {
wp_die( __( 'Sorry, you are not allowed to install themes on this site.' ) );
wp_die( __( 'Sorry, you are not allowed to install themes on this site.' ), 403 );
}

if ( is_multisite() && ! is_network_admin() ) {
Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/themes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
exit;
} elseif ( 'enable-auto-update' === $_GET['action'] ) {
if ( ! ( current_user_can( 'update_themes' ) && wp_is_auto_update_enabled_for_type( 'theme' ) ) ) {
wp_die( __( 'Sorry, you are not allowed to enable themes automatic updates.' ) );
wp_die( __( 'Sorry, you are not allowed to enable themes automatic updates.' ), 403 );
}

check_admin_referer( 'updates' );
Expand All @@ -103,7 +103,7 @@
exit;
} elseif ( 'disable-auto-update' === $_GET['action'] ) {
if ( ! ( current_user_can( 'update_themes' ) && wp_is_auto_update_enabled_for_type( 'theme' ) ) ) {
wp_die( __( 'Sorry, you are not allowed to disable themes automatic updates.' ) );
wp_die( __( 'Sorry, you are not allowed to disable themes automatic updates.' ), 403 );
}

check_admin_referer( 'updates' );
Expand Down
Loading