Ensure upgrade tests do not test past the specified version #10112
+113
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd31b4c.
desrosj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #10099.
Currently, if you manually dispatch a run of the upgrade testing workflow with a version that is lower than the currently supported major version, the tests run past the specified version instead of stopping when appropriate.
For example, this run was dispatched for version
6.6.4. The jobs spawned included "Upgrading 6.7 to 6.6.4" and "Upgrading 6.8 to 6.6.4)" despite6.6.4being older than those two major versions.The logic does not account for this and no upgrade is actually performed (technically this is a scenario where a downgrade would be tested) because the
--forceargument is not passed to thewp core updatecommand.This PR adds consideration for this scenario through a new job that generates a list of exclusions for all following strategy matrices.
.0(6.0.0).0(5.9)vappended (v5.5.10)vappended and trailing.0(v5.7.0)vappended and no trailing.0(v5.2)Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.