-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix some instances of null array key access #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some instances of null array key access #10136
Conversation
Update parameter type hint for is_registered method.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Follow-up to #9849 |
How did you encounter these? #9845 doesn't report them, which would indicate a lack of test coverage. |
Yes. |
Yes there is a lack of test coverage? In that case, some tests would be great :-) |
Add test for is_registered method with empty source name
This file contains unit tests for the WP_Block_Styles_Registry class, specifically testing the is_registered() method with various scenarios.
tests/phpunit/tests/block-pattern/wpBlockPatternCategoriesRegistry.php
Outdated
Show resolved
Hide resolved
Curious to see any stack traces where these happen in action too, to find the root cause |
Trac ticket: https://core.trac.wordpress.org/ticket/63957
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.