Use a real dataprovider instead of a method called and looped. #10137
Conversation
`get_my_sites_network_menu_items` was essentially being used as a dataprovider before without the benefit of being an actual dataprovider.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Thanks @aaronjorbin for PR!
Left minor feedback that correct the document for data provider param.
| /** | ||
| * @ticket 39082 | ||
| * @group ms-required | ||
| * @dataProvider data_my_sites_network_menu_items |
There was a problem hiding this comment.
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @param string $id The ID of the menu item. | |
| * @param string $cap The capability required to see the menu item. |
| /** | ||
| * @ticket 39082 | ||
| * @group ms-required | ||
| * @dataProvider data_my_sites_network_menu_items |
There was a problem hiding this comment.
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @param string $id The ID of the menu item. | |
| * @param string $cap The capability required to see the menu item. |
| /** | ||
| * @ticket 39082 | ||
| * @group ms-required | ||
| * @dataProvider data_my_sites_network_menu_items |
There was a problem hiding this comment.
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @dataProvider data_my_sites_network_menu_items | |
| * | |
| * @param string $id The ID of the menu item. | |
| * @param string $cap The capability required to see the menu item. |
|
This was committed in https://core.trac.wordpress.org/changeset/60894 @mukeshpanchal27 If you want to a new PR for those I can commit it but I think in general we are a lot more slack with docs for unit test related things |
get_my_sites_network_menu_itemswas essentially being used as a dataprovider before without the benefit of being an actual dataprovider.Trac ticket: https://core.trac.wordpress.org/ticket/63167
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.