Use dataproviders in auth tests #10138
Conversation
Also add a few additional test cases.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $this->assertInstanceOf( 'WP_User', $authed_user ); | ||
| $this->assertSame( $this->user->ID, $authed_user->ID ); | ||
| } | ||
| public function data_passwords_for_trimming() { |
There was a problem hiding this comment.
| public function data_passwords_for_trimming() { | |
| public static function data_passwords_for_trimming() { |
|
|
||
| $password = "pass with vertical tab o_O\x0B"; | ||
| $this->assertTrue( wp_check_password( 'pass with vertical tab o_O', wp_hash_password( $password ) ) ); | ||
| public function data_passwords_with_whitespace() { |
There was a problem hiding this comment.
| public function data_passwords_with_whitespace() { | |
| public static function data_passwords_with_whitespace() { |
|
This was committed in https://core.trac.wordpress.org/changeset/60895 @mukeshpanchal27 I know that non-static dataProviders are deprecated as of phpunit 10. I think we are best off switching all of them as a part of https://core.trac.wordpress.org/ticket/62004 |
dataproviders allow for the tests to all run rather than stopping at one failure. They also provide for better messages on failure.
Trac ticket: https://core.trac.wordpress.org/ticket/63167
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.