-
Notifications
You must be signed in to change notification settings - Fork 3.1k
REST API media endpoint: Update post relation to use api.w.org namespace / prefix #10163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
||
if ( ! empty( $post ) ) { | ||
$links['post'] = array( | ||
$links['https://api.w.org/post'] = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it break the BC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it break the BC?
No, there's no breaking change here as this hasn't made it into a release yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I forgot about this URI relation too.
I've just updated to rename to |
Thanks @andrewserong If it's good with @TimothyBJacobs then it still LGTM |
Thanks for re-reviewing! I'll see if there's any feedback overnight and hopefully commit this tomorrow. |
This PR updates the
post
link within the REST API media attachment response to use thehttps://api.w.org/
prefix, aspost
isn't a valid IANA link relation: https://www.iana.org/assignments/link-relations/link-relations.xhtmlKudos @TimothyBJacobs for catching this.
Testing instructions
These are basically the same testing instructions as in #10027:
If you'd like to test this from within the block editor:
Trac ticket: https://core.trac.wordpress.org/ticket/64034
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.