Allow POST requests in endpoint for ServerSideRender block component
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow <ServerSideRender> components to have a large attributes object, ideally it could POST attributes instead of making a GET request for them. So add support for a POST request in this endpoint that <ServerSideRender> uses.
Following the convention of other test methods.
6 tasks
|
It doesn't look like the Travis failures are related to this PR, though maybe I missed something. |
|
WordPress/gutenberg#21068 is what actually uses this PR's addition of |
Instead of having attributes be the entire body, they are now simply a property of the body.
The test didn't fail locally, so this might not work.
|
Nice, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a block's
<ServerSideRender>component to make aPOSTrequest, in case the attributes are too big for aGETrequest.There have been several cases where sending the attributes in the
GETrequest URL causes an error:WordPress/gutenberg#19935
WordPress/gutenberg#16396 (comment)
https://wordpress.org/support/topic/error-loading-block-the-response-is-not-a-valid-json-response-2/
This follows the suggestion in 2 of those issues to allow using
POSTfor the block endpoint, in addition toGET.Trac ticket: https://core.trac.wordpress.org/ticket/49680
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.