Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty-Two: allow negative margins for cover block to stack. #2223

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

jffng
Copy link

@jffng jffng commented Jan 24, 2022

Originally created in TT2's development repo by @erikjoling 🎉

Before After
Screen Shot 2022-01-20 at 12 02 50 PM Screen Shot 2022-01-20 at 12 03 13 PM

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@jffng
Copy link
Author

jffng commented Feb 7, 2022

@kjellr on revisiting this PR, I'm not quite understanding the use case. When I add an alignfull cover block, I can't add an align full group inside it; the alignment controls aren't present:

Kapture.2022-02-07.at.10.34.54.mp4

@kjellr
Copy link

kjellr commented Feb 7, 2022

Yeah, it’s more for existing content, or for when WordPress/gutenberg#37036 (comment) lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants