Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve block loading PHP performance #2252
Improve block loading PHP performance #2252
Changes from all commits
76d4e5f
4354737
fefeb15
bf10bc9
6594e1f
2aae58c
aa12bf2
8ec0097
d4735c0
6ca926a
3c3f127
e566421
2365f8c
e795b35
9f41dfe
d72673e
2268110
5a6743e
a30ebe8
bc7a284
4de00f6
7f5fc1e
4ce978a
0fa6460
9788cfc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using the same paths passed to the
register_block_type
as keys in the generated file? This way, you could do a simple check:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't those paths absolute - which means they'd change from site to site? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking you could set a variable to use in keys for the generated PHP file:
Maybe, it's too much work in a bit different place 😄
Large diffs are not rendered by default.