[Backport] Add wp_theme_element_class_name() alias
#3244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
requested changes
Sep 14, 2022
src/wp-includes/theme.php
Outdated
| * | ||
| * @return string The name of the class. | ||
| * | ||
| * @since 6.1.0 |
There was a problem hiding this comment.
Minor: @param and @return should come after @since.
costdev
requested changes
Sep 14, 2022
costdev
reviewed
Sep 14, 2022
src/wp-includes/theme.php
Outdated
| * | ||
| * @return string The name of the class. | ||
| */ | ||
| function wp_theme_element_class_name( $element ) { |
There was a problem hiding this comment.
For consistency with the original method, and for consistent use of the active verb, I'd suggest renaming this alias to wp_theme_get_element_class_name(). 🙂
There was a problem hiding this comment.
Makes sense! That does have a nicer ring to it 😊
|
Since the unit test errors seem spurious (see), I'll try rebasing to kick them off again. |
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
ockham
force-pushed
the
backport/wp-theme-element-class-name
branch
from
06618d5 to
4c85024
Compare
|
Committed in https://core.trac.wordpress.org/changeset/54174 @ockham I'll let you close this PR if everything is ok :) |
|
Oops, I closed it accidentally :D |
No worries @audrasjb 😄 Thank you for committing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
wp_theme_element_class_name()alias for the "internal"WP_Theme_JSON::get_element_class_name().Backport of @c4rl0sbr4v0s' WordPress/gutenberg#44099.
See this discussion for the rationale.
Note that I've opted not to replace calls to
WP_Theme_JSON::get_element_class_namein the tests -- since those are specifically for theWP_Theme_JSONclass.Trac ticket: https://core.trac.wordpress.org/ticket/56467
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.