-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport block editor persisted preferences (refresh) #3253
Backport block editor persisted preferences (refresh) #3253
Conversation
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
tests/phpunit/tests/user/wpRegisterPersistedPreferencesMeta.php
Outdated
Show resolved
Hide resolved
It's talldanwp on wordpress.org. Thanks for adding the tests. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could a Core committer please apply the test variable change, and apply with (with props to noisysocks
costdev
talldanwp
)? 😊
Test ReportEnv:
Tests and ResultsAll tests will use Chrome and Firefox to check if preferences persist between browsers and on reload in same browser. Test 1: Posts UIChanging preferences in one browser:
Test 2: Site EditorChanging preferences in one browser:
Test 3: Should not change other UIsChanging preferences in Post UI should not change Site Editor preferences ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected ✅
Meets coding standards ✅
Tests pass ✅
All concerns addressed ✅
Prepping commit
Committed via https://core.trac.wordpress.org/changeset/54182. Thank you everyone for your contributions! |
Refresh of #3219.
wp_register_persisted_preferences_meta
function.Trac ticket: https://core.trac.wordpress.org/ticket/56467
Props noisysocks costdev talldanwp
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.