Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport block editor persisted preferences (refresh) #3253

Conversation

ironprogrammer
Copy link

@ironprogrammer ironprogrammer commented Sep 14, 2022

Refresh of #3219.

  • Adds PHPunit test for new wp_register_persisted_preferences_meta function.
  • Validates registration and structure of meta key.

Trac ticket: https://core.trac.wordpress.org/ticket/56467

Props noisysocks costdev talldanwp


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@talldan
Copy link
Contributor

talldan commented Sep 15, 2022

Props noisysocks costdev talldan

It's talldanwp on wordpress.org. Thanks for adding the tests. 😄

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Could a Core committer please apply the test variable change, and apply with (with props to noisysocks costdev talldanwp)? 😊

cc/ @audrasjb @hellofromtonya

@hellofromtonya hellofromtonya self-assigned this Sep 15, 2022
@hellofromtonya
Copy link
Contributor

Test Report

Env:

  • OS: macOS Monterey
  • Localhost: wp-env
  • Plugins: none
  • Theme: TT2
  • Browsers: Chrome and Firefox

Tests and Results

All tests will use Chrome and Firefox to check if preferences persist between browsers and on reload in same browser.

Test 1: Posts UI

Changing preferences in one browser:

  • should persist in same browser on page load ✅
  • should persist in the other browser on page load ✅

persist-post

Test 2: Site Editor

Changing preferences in one browser:

  • should persist in same browser on page load ✅
  • should persist in the other browser on page load ✅

persist-site-editor

Test 3: Should not change other UIs

Changing preferences in Post UI should not change Site Editor preferences ✅

persist-screensgif

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅
Meets coding standards ✅
Tests pass ✅
All concerns addressed ✅

Prepping commit

@hellofromtonya
Copy link
Contributor

Committed via https://core.trac.wordpress.org/changeset/54182. Thank you everyone for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants