Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Alternative) Backport script loader: enqueue stored block supports styles (3rd attempt) #3262

Conversation

andrewserong
Copy link
Contributor

@andrewserong andrewserong commented Sep 16, 2022

This is another fork of #3218, to attempt to fix the tests that are broken in #3259 (this PR is a direct copy + paste of #3259, with an update to the tests to expect different results depending on the value of SCRIPT_DEBUG).

Original PR desc:

Backporting changes to script-loader that enqueue block support styles stored by the style engine/

See tracking issue: WordPress/gutenberg#43440

Backporting the following changes

Trac ticket: https://core.trac.wordpress.org/ticket/56467


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@andrewserong andrewserong force-pushed the add/enqueue-stored-block-supports-styles-with-tests-for-script-debug branch from 31dd1d4 to ce07ae8 Compare September 16, 2022 01:47
@andrewserong andrewserong marked this pull request as ready for review September 16, 2022 01:57
@andrewserong
Copy link
Contributor Author

Closing now that #3273 has landed instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants