Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run NPM Test in Windows #3302

Closed
wants to merge 4 commits into from

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Sep 21, 2022

Disable the NPM Test CI workflow in Windows. This is a workaround for this issue so it doesn't get in the way of WP 6.1 Beta 1.

The issue is being actively investigated here.

Trac ticket:

cc/ @Clorith @t-hamano @desrosj @gziolo @jsnajdr @c4rl0sbr4v0


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Sep 21, 2022
@ockham ockham marked this pull request as ready for review September 21, 2022 12:35
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use continue-on-error here instead.

That way, the job continues to run and provides feedback so we can track any changes to this behavior over time as debugging continues.

.github/workflows/test-npm.yml Show resolved Hide resolved
.github/workflows/test-npm.yml Outdated Show resolved Hide resolved
@ockham
Copy link
Contributor Author

ockham commented Sep 21, 2022

Good point, thank you! I'll apply your suggestions 👍

ockham and others added 2 commits September 21, 2022 15:17
Co-authored-by: Jon Desrosiers <desrosj@users.noreply.github.com>
Co-authored-by: Jon Desrosiers <desrosj@users.noreply.github.com>
@desrosj
Copy link
Contributor

desrosj commented Sep 21, 2022

@desrosj desrosj closed this Sep 21, 2022
@ockham ockham deleted the remove/test-npm-windows-env branch November 16, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants