Sync packages for WP 6.1 Beta 2 #3342
Conversation
ockham
requested review from
SergeyBiryukov,
gziolo,
audrasjb and
hellofromtonya
| $color_block_styles['background'] = $preset_background_color ? $preset_background_color : $custom_background_color; | ||
|
|
||
| // Generate color styles and classes. | ||
| $styles = gutenberg_style_engine_get_styles( array( 'color' => $color_block_styles ), array( 'convert_vars_to_classnames' => true ) ); |
There was a problem hiding this comment.
@ockham The prefix should be changed to wp_ instead of gutenberg_.
There was a problem hiding this comment.
Ugh, I missed that one. I'll fix it.
There was a problem hiding this comment.
Sidenote, I don't quite understand how this ended up here. The relevant GB PR (WordPress/gutenberg#42029) was only merged after GB 14.1 was released, and we didn't cherry-pick it to the wp/6.1 branch. In fact, the relevant code is absent from that file in Gutenberg's wp/6.1 branch 🤔
There was a problem hiding this comment.
Looks like the script picked up the wrong package version(s): For @wordpress/block-library, I see 7.15.0.
But the wp-6.1 tag points to 7.14.3.
I think we had a similar issue before with #3154, but I'm not 100% sure what @gziolo did to fix it...
There was a problem hiding this comment.
I think I forgot to specify the dist-tag. Note to future self:
npm run sync-gutenberg-packages -- --dist-tag=wp-6.1
There was a problem hiding this comment.
Please hold off reviewing this -- it appears that the sync script picked up the wrong package versions.
|
I've reverted the original commit and run FWIW, GitHub Status is showing some issue with GH Actions (but no other GH components). |
|
Closing. This PR has been flaky, and we've decided that we don't want to include WordPress/gutenberg#43862, so we'll need to revert that on GB's |
|
New sync PR: #3345 |
Includes the latest round of Gutenberg bugfix PRs that were approved for inclusion during yesterday’s triage session.
Needed for today's WP 6.1 Beta 2 release (scheduled in ~3 hours from now).
Trac ticket: https://core.trac.wordpress.org/ticket/56467
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.