Global Styles: Update the order of pseudo selectors #3582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Mamaduka! I changed the ticket description to point to Trac-56928 since that ticket is specific to this issue/change. |
desrosj
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
This looks good, but let's include the Trac ticket link for additional context as to why the selectors are ordered as such. I can add this comment when committing, but wanted to make sure you agreed.
Also, I'm indifferent as to whether this needs to be synced to the Gutenberg plugin as that class should disappear in a few releases. But it may be good for consistency.
Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com>
|
Thank you, @desrosj. The Trac ticket link makes sense to me, I will port changes back to the plugin for consistency 👍 |
peterwilsoncc
approved these changes
Nov 9, 2022
|
Thank you, @peterwilsoncc. Now the only thing left is to cherry-pick the commit for the 6.1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes from WordPress/gutenberg#45559
Props: @mikachan, @sabernhardt, @getdave (get_dave).
Trac ticket: https://core.trac.wordpress.org/ticket/56928
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.