Remove unused wp-nux css dependencies. #3910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
@peterwilsoncc Makes sense to me. Would be great to also get @youknowriad's feedback on this.
|
Well obviously, that's the minimum we should be doing. I think it's not enough and we discussed this over and over again already though. |
peterwilsoncc
force-pushed
the
fix/css-dependencies-nux
branch
from
c467dd6
to
f5baaec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to PR #3775 for deprecating nux WordPress/gutenberg#46110
In the discussion for the original pull request, it seems the
wp-edit-postandwp-editorstyles no longer require thewp-nuxcss file as a dependency.This removes the CSS dependencies while retaining the JavaScript to ensure JavaScript continues to function for extenders still using the nux package. As the styles are not needed, this will see a small performance gain for most WordPress installs.
Trac tickets: