-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the WordPress packages with Gutenberg 15.1.0 changes #3914
Conversation
3f017de
to
74dd9f2
Compare
I noticed that we have a few methods with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad Mostly looks good, just one nit-pick and the remaining gutenberg_
prefixes that need to be replaced. Is that something you can just update in this PR or does it require a fix on the Gutenberg side?
Other than that, I assume the intention is to commit this once #3920 has been committed?
@felixarntz, I already fixed @ntsekouras and I will start working on package updates that include recent fixes. |
Actually, I can't touch these files here, even the nitpicks suggested here because every time someone will do |
0bd165f
to
c7ea6e2
Compare
I've just noticed that there's a blocks fixtures tests in Core right now. Anyone know why this test has been moved from Gutenberg to here? It's just going to add maintenance burden for us for a small value since all the code for blocks is coming through package. In other words, these tests are better by their code (in the Gutenberg repo). |
Ok I've managed to fix all the failing tests here. It's not perfect but It should be good to land to unblock the PRs that depend on it. I've noticed a small style glitch on the empty post placeholder. Something to keep an eye on after all the backports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad LGTM. Would still be nice to address https://github.com/WordPress/wordpress-develop/pull/3914/files#r1095179123, though that is not a blocker.
@felixarntz It needs to be addressed on Gutenberg, that way it comes in the next package update. You can't make changes to these files in Core. |
@youknowriad Ah right, forgot about that, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to land this. Thank you Riad!
This has been committed |
Thank you, Riad! The changeset - https://core.trac.wordpress.org/changeset/55246. |
This PR updates the WordPress packages with the latest released ones from Gutenberg 15.1.0
While updating the packages, it was necessary to bring the following changes as well:
Trac ticket: https://core.trac.wordpress.org/ticket/57471