Backport _wp_get_iframed_editor_assets #4700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @ellatrix for the PR.
The document for global variable is missing.
The multiline comment suggestions are based on the fact that the PRs on this ticket should correct all other "multiple single line comments" in this file, so we might as well avoid introducing new ones in this PR and having to update the other one.
| @@ -297,65 +297,72 @@ function get_legacy_widget_block_editor_settings() { | |||
| * } | |||
| */ | |||
| function _wp_get_iframed_editor_assets() { | |||
| global $pagenow, $editor_styles; | |||
| global $wp_styles, $wp_scripts, $pagenow; | |||
There was a problem hiding this comment.
Add missing documents for $wp_styles and $wp_scripts
|
Looks like |
oandregal
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Code-wise looks good.
I've tested that is working as expected by looking at what are the assets that are loaded through __unstableResolvedAssets and the ones loaded in the iframe:
- scripts: the same before/after
- styles:
__unstableResolvedAssetscontains now thewp-edit-site-css, as expected (it was loaded through the compat layer before). It also contains the emoji CSS, as expected (we're now loading all assets present in the front).
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes from:
Trac ticket: https://core.trac.wordpress.org/ticket/58626
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.