Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add allowed_blocks field to block registration and REST API #5988

Closed
wants to merge 3 commits into from

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Jan 31, 2024

There is a new block.json field called allowedBlocks, added in Gutenberg in WordPress/gutenberg#58262. This is a companion patch to support this new field also on the server. It ensures that the following works:

  1. If the allowedBlocks field is defined in block's block.json, the objects registered in WP_Block_Type_Registry will have the allowed_blocks field.
  2. The allowed_blocks field is returned by the /wp/v2/block-types REST endpoint.
  3. The allowedBlocks field will be included in the boostrapped block registration data in the unstable__bootstrapServerSideBlockDefinitions inline script.

Trac ticket: https://core.trac.wordpress.org/ticket/60403


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@gziolo
Copy link
Member

gziolo commented Feb 1, 2024

allowed_blocks should be also explicitly defined in WP_Block_Type class.

@jsnajdr
Copy link
Member Author

jsnajdr commented Feb 1, 2024

allowed_blocks should be also explicitly defined in WP_Block_Type class.

Done ✅

@gziolo
Copy link
Member

gziolo commented Feb 1, 2024

CI is unhappy about something. Other than that, I have enough to commit it tomorrow.

Copy link

github-actions bot commented Feb 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: jsnajdr, gziolo.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo
Copy link
Member

gziolo commented Feb 2, 2024

Committed with https://core.trac.wordpress.org/changeset/57521.

@gziolo gziolo closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants