-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings API: Create WP_Block_Bindings_Source
class
#6042
Block Bindings API: Create WP_Block_Bindings_Source
class
#6042
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
WP_Block_Bindings_Source
class
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping up nicely. I really like how the new class improves the readability of the code and how the refactoring brought attention to additional validation for the properties passed.
I left my feedback for potential improvements.
|
||
self::$test_source_properties = array( | ||
'label' => 'Test source', | ||
'get_value_callback' => function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would be possible to inject only get_value_callback
here, but we can change that with the refactoring. Overall, that makes perfect sense to use a static variable 👍🏻
Committed with https://core.trac.wordpress.org/changeset/57562. |
This PR refactors the array of Block Binding sources into its own
WP_Block_Bindings_Source
class.This change was previously discussed in WordPress/gutenberg#53300 (comment)
Reasons for this change
Trac ticket: https://core.trac.wordpress.org/ticket/60447#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.