Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export font families and font faces post on site export #6173

Conversation

matiasbenedetto
Copy link

@matiasbenedetto matiasbenedetto commented Feb 23, 2024

What?

Export font families (wp_font_family post type) and font faces (wp_font_face post type) posts when exporting a site.

Why?

To export this new type of content handled by Wordpress.

How?

Exporting wp_font_family and wp_font_face post types when exporting a site.

Note

This is just the export part. The import part will be implemented in the wordpress-importer repo: WordPress/wordpress-importer#160


Trac ticket: https://core.trac.wordpress.org/ticket/60626


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@matiasbenedetto matiasbenedetto marked this pull request as draft February 23, 2024 17:57
Copy link

github-actions bot commented Feb 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mmaattiiaass, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Contributor

can_export defaults to true so only the PR for the importer will be required.

On the Tools > Export screen selecting all content will include the site editor post types (fonts, templates, etc).

@matiasbenedetto
Copy link
Author

can_export defaults to true so only the PR for the importer will be required.

Good call, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants