-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename data_wp_context
to wp_interactivity_data_wp_context
#6205
Conversation
cc @luisherranz |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
It works for me. @c4rl0sbr4v0 and @DAreRodz, can we proceed with it? It will require changes in WordPress packages for core blocks and adjustment to the dev note. |
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Sure @gziolo . |
Thanks y'all! Committed in https://core.trac.wordpress.org/changeset/57742 |
Renames the function for more clarity.
Important: requires a corresponding change to the block render callbacks in Gutenberg
Trac ticket: https://core.trac.wordpress.org/ticket/60575
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.