Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data_wp_context to wp_interactivity_data_wp_context #6205

Closed
wants to merge 2 commits into from

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Feb 29, 2024

Renames the function for more clarity.

Important: requires a corresponding change to the block render callbacks in Gutenberg

Trac ticket: https://core.trac.wordpress.org/ticket/60575


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@swissspidy
Copy link
Member Author

cc @luisherranz

Copy link

github-actions bot commented Feb 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props swissspidy, gziolo, cbravobernal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo
Copy link
Member

gziolo commented Feb 29, 2024

It works for me. @c4rl0sbr4v0 and @DAreRodz, can we proceed with it? It will require changes in WordPress packages for core blocks and adjustment to the dev note.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@cbravobernal
Copy link
Contributor

It works for me. @c4rl0sbr4v0 and @DAreRodz, can we proceed with it? It will require changes in WordPress packages for core blocks and adjustment to the dev note.

Sure @gziolo .
Dev note is updated. Handbook and Gutenberg updates are available here:

WordPress/gutenberg#59465

@swissspidy
Copy link
Member Author

Thanks y'all! Committed in https://core.trac.wordpress.org/changeset/57742

@swissspidy swissspidy closed this Feb 29, 2024
@swissspidy swissspidy deleted the fix/60575-rename branch February 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants