Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naive filtering of uploads directory. #6211

Closed
wants to merge 43 commits into from
Closed

Fix naive filtering of uploads directory. #6211

wants to merge 43 commits into from

Commits on Mar 4, 2024

  1. Test naive filtering of uploads directory.

    @peterwilsoncc
    peterwilsoncc committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c6844b3 View commit details
    Browse the repository at this point in the history

  2. Prevent infinite loop filtering fonts directory. Props @costdev.

    @peterwilsoncc
    peterwilsoncc committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b64bfae View commit details
    Browse the repository at this point in the history

  3. Restore naive filtering to rest end point.

    @peterwilsoncc
    peterwilsoncc committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c1edfba View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a866973 View commit details
    Browse the repository at this point in the history

  2. Thought bubble…

    @peterwilsoncc
    peterwilsoncc committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    19cc1c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    a8f9edf View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d8dfbf5 View commit details
    Browse the repository at this point in the history

  2. Improve comment.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a10dbe4 View commit details
    Browse the repository at this point in the history

  3. Move the font directory filter registration.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2b21c6d View commit details
    Browse the repository at this point in the history

  4. Remove cache option: N/A for fonts.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ba51db2 View commit details
    Browse the repository at this point in the history

  5. Docblocks.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d0ef78e View commit details
    Browse the repository at this point in the history

  6. Improve comment.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3277002 View commit details
    Browse the repository at this point in the history

  7. More docblocks.

    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    db876de View commit details
    Browse the repository at this point in the history

  8. Use static for closure. 

    Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
    @peterwilsoncc @mukeshpanchal27
    peterwilsoncc and mukeshpanchal27 authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cec16c6 View commit details
    Browse the repository at this point in the history

  9. Revert "Use static for closure." 

    This reverts commit cec16c6.
    @peterwilsoncc
    peterwilsoncc committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    94c576b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Font uploads.

    @peterwilsoncc
    peterwilsoncc committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    eff1763 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Dockblock improvements 

    Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
    @peterwilsoncc @costdev
    peterwilsoncc and costdev authored Mar 10, 2024
    Configuration menu
    Copy the full SHA
    48aca49 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    606aeae View commit details
    Browse the repository at this point in the history

  3. Avoid duplicate assertions testing for loop.

    @peterwilsoncc
    peterwilsoncc committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    5117eef View commit details
    Browse the repository at this point in the history

  4. Doc fix.: this not the.

    @peterwilsoncc
    peterwilsoncc committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    4b76a9c View commit details
    Browse the repository at this point in the history

  5. Font upload, not upload dir.

    @peterwilsoncc
    peterwilsoncc committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    addadc3 View commit details
    Browse the repository at this point in the history

  6. Trolling?

    @peterwilsoncc
    peterwilsoncc committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    c1ac4e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3221610 View commit details
    Browse the repository at this point in the history

  2. Rename function.

    @peterwilsoncc
    peterwilsoncc committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    1c870cc View commit details
    Browse the repository at this point in the history

  3. Filter the font directory late.

    @peterwilsoncc
    peterwilsoncc committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    1c3b7ac View commit details
    Browse the repository at this point in the history

  4. Document late running hook.

    @peterwilsoncc
    peterwilsoncc committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    fb2cfc3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    607a73a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    41bbeb7 View commit details
    Browse the repository at this point in the history

  2. Rename function to use plural filters. 

    Co-authored-by: costdev <costdev@git.wordpress.org>
    @peterwilsoncc @costdev
    peterwilsoncc and costdev committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    52103f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Remove a a typo. 

    Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
    @peterwilsoncc @costdev
    peterwilsoncc and costdev authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    21673e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bf2c2fd View commit details
    Browse the repository at this point in the history

  3. Run filter at default priority. 

    As the filter is created while getting the upload directory in `wp_upload_dir()` the core filter should be added after any plugins filter the uploads directory during the init or an earlier hook.
    @peterwilsoncc
    peterwilsoncc committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1183132 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f2d5a77 View commit details
    Browse the repository at this point in the history

  2. Remove out of date comment.

    @peterwilsoncc
    peterwilsoncc committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0204b99 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9071275 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    022941e View commit details
    Browse the repository at this point in the history

  2. Merge default getter and filtering function. Rename.

    @peterwilsoncc
    peterwilsoncc committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    eccdbac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    f9e41b2 View commit details
    Browse the repository at this point in the history

  4. Rename function. Props @swissspidy.

    @peterwilsoncc
    peterwilsoncc committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    22764e3 View commit details
    Browse the repository at this point in the history

  5. Document use of filter.

    @peterwilsoncc
    peterwilsoncc committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    cf211ae View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Add ticket reference

    @swissspidy
    swissspidy authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    35f8e1b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into fix/font-filter-infinite-loop

    @peterwilsoncc
    peterwilsoncc committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ed46c1d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/font-filter-infinite-loop' of github.com:peterwilso… 

    …ncc/wordpress-develop into fix/font-filter-infinite-loop
    @peterwilsoncc
    peterwilsoncc committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7721163 View commit details
    Browse the repository at this point in the history