Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON: Add missing i18n for variations #6825

Conversation

aaronrobertshaw
Copy link

@aaronrobertshaw aaronrobertshaw commented Jun 14, 2024

This PR backports WordPress/gutenberg#62552

The changes included add support for internationalizing the block style variations labels defined from a theme.json or theme style variation file.

Test Instructions

In the theme.json of the theme, paste the following contents under styles.blocks.variations:

"myvariation": {
    "title": "My Variation",
    "blockTypes": ["core/group"],
    "color": {
        "background": "var(--wp--preset--color--base-2)"
    }
}
Without the title With the title
Captura de ecrã 2024-06-13, às 21 51 45 Captura de ecrã 2024-06-13, às 21 52 04

Trac ticket: https://core.trac.wordpress.org/ticket/61442


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jun 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, oandregal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal
Copy link
Member

This PR also unblocks changes at the i18n-command at wp-cli/i18n-command#405 that depend on this schema change.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@oandregal
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants