-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Replace null-bytes in class_list class names #7187
HTML API: Replace null-bytes in class_list class names #7187
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of an audit of HTML API CSS behaviors, this patch resolves an issue with how the HTML API reports class names containing the NULL byte. NULL bytes should be replaced by the Unicode replacement character, U+FFFD, but previously weren't. This patch performs that replacement. Developed in #7187 Discussed in https://core.trac.wordpress.org/ticket/61531 Follow-up to [56703]. Props dmsnell, jonsurrell. See #61531. git-svn-id: https://develop.svn.wordpress.org/trunk@58969 602fd350-edb4-49c9-b593-d223f7449a82
As part of an audit of HTML API CSS behaviors, this patch resolves an issue with how the HTML API reports class names containing the NULL byte. NULL bytes should be replaced by the Unicode replacement character, U+FFFD, but previously weren't. This patch performs that replacement. Developed in WordPress/wordpress-develop#7187 Discussed in https://core.trac.wordpress.org/ticket/61531 Follow-up to [56703]. Props dmsnell, jonsurrell. See #61531. Built from https://develop.svn.wordpress.org/trunk@58969 git-svn-id: http://core.svn.wordpress.org/trunk@58365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As part of an audit of HTML API CSS behaviors, this patch resolves an issue with how the HTML API reports class names containing the NULL byte. NULL bytes should be replaced by the Unicode replacement character, U+FFFD, but previously weren't. This patch performs that replacement. Developed in WordPress/wordpress-develop#7187 Discussed in https://core.trac.wordpress.org/ticket/61531 Follow-up to [56703]. Props dmsnell, jonsurrell. See #61531. Built from https://develop.svn.wordpress.org/trunk@58969 git-svn-id: https://core.svn.wordpress.org/trunk@58365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
I'm pretty confident that with |
Absolutely @sirreal - but I'm speaking more about WPCS conventions than working code. I know there are examples in the codebase already demonstrating |
As part of an audit of HTML API CSS behaviors, this patch resolves an issue with how the HTML API reports class names containing the NULL byte. NULL bytes should be replaced by the Unicode replacement character, U+FFFD, but previously weren't. This patch performs that replacement. Developed in WordPress#7187 Discussed in https://core.trac.wordpress.org/ticket/61531 Follow-up to [56703]. Props dmsnell, jonsurrell. See #61531. git-svn-id: https://develop.svn.wordpress.org/trunk@58969 602fd350-edb4-49c9-b593-d223f7449a82
Replace null bytes with the � replacement character in
::class_list
.The browser will replace null bytes with � in attribute values:
If we consider that class_list is a processed version of the class attribute, this null-byte replacement is appropriate. At this time, get_attribute is closer to "raw" access to the attribute value as authored.
Related to #7184.
Trac ticket: https://core.trac.wordpress.org/ticket/61531
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.